[Webkit-unassigned] [Bug 104114] New: [GTK] coverity warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104114

           Summary: [GTK] coverity warnings
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: danw at gnome.org


>From an internal coverity run; webkitgtk3-1.10.1-1.fc18 had a total of 2652 warnings (most of which were weird C++ things), so I only looked at the gtk-specific ones...


Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1236 does
        soupMessage ? soupMessage->method : "(none)"));
but soupMessage was already verified to be non-NULL at line 1226


Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:741 checks if inputElement is NULL, but inputElement is just a cast of coreNode which was already verified to be non-NULL at line 737.


Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:430 calls parent->children(), but line 427 suggests that parent might be NULL.


Source/WebCore/platform/gtk/ClipboardGtk.cpp:122 might be missing a "break;" (likewise the case below that one).


Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:87 calls m_client->currentlyProcessedMouseDownEvent(), but then later at line 108 checks if m_client is NULL

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.