[Webkit-unassigned] [Bug 104108] Web Inspector: Title of "Record Timeline" status button on "Timeline Panel" should be toggled upon the recording state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104108


Alexander Pavlov (apavlov) <apavlov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177715|review?                     |
               Flag|                            |




--- Comment #3 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-12-05 04:17:00 PST ---
(From update of attachment 177715)
View in context: https://bugs.webkit.org/attachment.cgi?id=177715&action=review

> Source/WebCore/ChangeLog:4
> +        Panel" should be toggled upon the recording state.

I'd put it as "...should reflect the recording state."

> Source/WebCore/inspector/front-end/TimelinePanel.js:556
> +            this.toggleTimelineButton.title = WebInspector.UIString("Stop");

The previous line looks like a more appropriate place for this line, since starting the record and toggling the title are logically related, and sending the metrics event is related to the entire sequence.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.