[Webkit-unassigned] [Bug 73671] [Qt] When turning off PluginsEnabled attribute then a QWebPage will still try to load plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73671


Jocelyn Turcotte <jocelyn.turcotte at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177683|review?                     |review-
               Flag|                            |




--- Comment #8 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2012-12-05 03:36:34 PST ---
(From update of attachment 177683)
View in context: https://bugs.webkit.org/attachment.cgi?id=177683&action=review

> Source/WebKit/qt/ChangeLog:6
> +        database for installed plugins.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=73671

Normally the summary have to be all on the first line, and the bug number on the second:

        Check that plugin functionality is enabled before querying the database for installed plugins.
        https://bugs.webkit.org/show_bug.cgi?id=73671

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1360
> -    if (PluginDatabase::installedPlugins()->isMIMETypeRegistered(mimeType))
> +    if (m_frame && arePluginsEnabled)

I think there is a part missing :)
And no need to check m_frame.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.