[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #36 from Kalyan <kalyan.kondapally at intel.com>  2012-12-05 00:29:04 PST ---
(In reply to comment #35)
> > K, I see that you had this in your earlier version. 
> > Unless I have missed something, Noam only suggested to have the implementation in TextureMapperPlatformLayer similar to what you have in Canvas2DLayerEFL. I think we should have a default implementation in TextureMapperPlatformLayer , similar to this:
> > 
> > bool hasGraphicsSurface() const
> > {
> > #if USE(GRAPHICS_SURFACE)
> >         return true;
> > #endif
> >     return false;
> > }
> > 
> > Any platform layer having custom checks could re-implement this function as you suggested.
> 
> This was along the lines of my thinking.
> However, I still fail to understand the value of accelerated 2D canvas in coordinated graphics without graphics surface. 
> What makes sense to me is to disable accelerated 2d canvas if graphics surfaces are disabled.

How about something like this:

TextureMapperPlatformLayer would have something like:
bool hasGraphicsSurface() const
 {
 #if USE(GRAPHICS_SURFACE)
         return true;
 #endif
     return false;
 }

and in coordinated graphics:
bool canvasHasGraphicsSurface()
{
return (m_canvasPlatformLayer &&  m_canvasPlatformLayer->hasGraphicsSurface());
}

PlatformLayer would be responsible for making the decision of using the graphics surface or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.