[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #34 from Kalyan <kalyan.kondapally at intel.com>  2012-12-04 21:55:35 PST ---
(In reply to comment #31)
> (In reply to comment #30)
> > (In reply to comment #29)
> > > (In reply to comment #28)
> > > > (In reply to comment #27)
> > > > > (In reply to comment #26)
> > > > > > (In reply to comment #23)
> > > > > > > Created an attachment (id=177414)
 --> (https://bugs.webkit.org/attachment.cgi?id=177414&action=review) [details] [details] [details] [details] [details] [details] [details]
> 
> if m_canvasPlatformlayer is null, it means there's no canvas layer for 2D here so the return value should be dependent on it.

This is the part which is bit confusing for me. The relevant code from the patch: 


bool CoordinatedGraphicsLayer::canvasHasGraphicsSurface() const
{
#if !USE(GRAPHICS_SURFACE)
    if (m_canvasPlatformLayer)
        return false;
#endif
    return true;
}

we would always return true in case of canvasPlatformlayer being null, irrespective of Graphics_Surface being supported or not.

> > > Actually, would it be better to query this from platformlayer itself rather than having it in graphicslayer??
> > 
> > I mean would it be better to query from platformLayer, if it is using a graphicssurface or not, rather than doing it in coordinatedgraphicslayer
> 
> It was. I checked it in Canvas2DLayerEfl originally. But it's been changed >by Noam's suggestion. Do you believe checking it in each platformLayer could >be better?

K, I see that you had this in your earlier version. 
Unless I have missed something, Noam only suggested to have the implementation in TextureMapperPlatformLayer similar to what you have in Canvas2DLayerEFL. I think we should have a default implementation in TextureMapperPlatformLayer , similar to this:

bool hasGraphicsSurface() const
{
#if USE(GRAPHICS_SURFACE)
        return true;
#endif
    return false;
}

Any platform layer having custom checks could re-implement this function as you suggested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.