[Webkit-unassigned] [Bug 103605] [CMake] Unify coding style for CMake files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103605





--- Comment #19 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-12-04 18:48:56 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > Nit: Having NOT (AND, etc) and APPEND (INSTERT, etc) also all lowercase would be more consistent and it would be easier to read. If this make sense, it could be in a follow-up patch.
> Refer to cmake doc (http://www.cmake.org/cmake/help/v2.8.10/cmake.html), the boolean expressions(AND, OR, NOT) are uppercase. Same as other keywords like APPEND, TARGETS, INSTALL are also uppercase. 

You are absolutely right, it is my bad. Thanks for checking.

> I'll remake the patch with removing changes for ThirdParty and ignore my newly add script.

Great, thanks !

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.