[Webkit-unassigned] [Bug 103605] [CMake] Unify coding style for CMake files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 4 17:55:02 PST 2012


--- Comment #17 from Halton Huo <halton.huo at gmail.com>  2012-12-04 17:57:27 PST ---
(In reply to comment #16)
> Nit: Having NOT (AND, etc) and APPEND (INSTERT, etc) also all lowercase would be more consistent and it would be easier to read. If this make sense, it could be in a follow-up patch.
Refer to cmake doc (http://www.cmake.org/cmake/help/v2.8.10/cmake.html), the boolean expressions(AND, OR, NOT) are uppercase. Same as other keywords like APPEND, TARGETS, INSTALL are also uppercase. With my testing, they must be uppercase, otherwise cmake report error. The following example will fails:

if (1 and 0)    #CMake error "Unknown arguments specified"
  list(append SOURCES #CMake error "list does not recognize sub-command append"
endif ()

So I'd like to keep them uppercase and won't check the style for those because developer will meet CMake failure as above.

I'll remake the patch with removing changes for ThirdParty and ignore my newly add script.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list