[Webkit-unassigned] [Bug 104043] Implement general ::cue pseudo element for the <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104043


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177621|review?                     |review+
               Flag|                            |




--- Comment #4 from Eric Carlson <eric.carlson at apple.com>  2012-12-04 17:51:49 PST ---
(From update of attachment 177621)
View in context: https://bugs.webkit.org/attachment.cgi?id=177621&action=review

> LayoutTests/media/track/track-css-all-cues.html:14
> +		<style>
> +
> +		video::cue { color:red }
> +
> +		</style>

It looks like you have a mixture of spaces and tabs in this file. Spaces only please.

> Source/WebCore/ChangeLog:13
> +        (WebCore):

This doesn't add anything and can be removed.

> Source/WebCore/ChangeLog:15
> +        (WebCore::MediaControlTextTrackContainerElement::createSubtrees):
> +        (WebCore::MediaControlTextTrackContainerElement::updateDisplay):

I prefer to see a comment about what changed in each method. Not everyone does this, but I think it makes it easier for people looking for information about changes later.

> Source/WebCore/ChangeLog:19
> +        (WebCore::MediaControlRootElement::createTextTrackDisplay):

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.