[Webkit-unassigned] [Bug 103513] Provide the backend for exposing the layer tree to the Web Inspector
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 4 14:30:15 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=103513
--- Comment #51 from Antoine Quint <graouts at apple.com> 2012-12-04 14:32:39 PST ---
(In reply to comment #47)
> (From update of attachment 177472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177472&action=review
>
> > LayoutTests/inspector-protocol/layer-tree.html:146
> > + function recurse (layer) {
>
> recurse(layer)
Fixed in 7th patch.
> > LayoutTests/inspector-protocol/layer-tree.html:168
> > + function replacer (key, value)
>
> style: no space after function name
Fixed in 7th patch.
> > LayoutTests/inspector-protocol/layer-tree.html:170
> > + return (key === "layerId") ? undefined : value;
>
> style: please drop redundant parenthesis
> we typically dump typeof value instead of value if value is non-stable -- this occasionally helps to catch regressions for values that are missing or of a wrong type.
Good point. I fixed that in the 7th patch.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list