[Webkit-unassigned] [Bug 103413] TextTrackCue's .endTime property should fire a TypeError when NaN is assigned

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103413


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177486|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Carlson <eric.carlson at apple.com>  2012-12-04 08:54:22 PST ---
(From update of attachment 177486)
View in context: https://bugs.webkit.org/attachment.cgi?id=177486&action=review

> Source/WebCore/html/track/TextTrackCue.cpp:273
> +    if (WTF::double_conversion::Double(value).IsSpecial()) {

I don't see Double() being used to test this anywhere else in WebCore, and while I don't know enough about it to know that it is a problem I would rather we stick with the more commonly used isinf() and isnan(). Note that you don't need to test for negative vs. positive infinity as inf() returns true for either (eg. see MediaTime::createWithDouble).

> Source/WebCore/html/track/TextTrackCue.cpp:290
> +    if (WTF::double_conversion::Double(value).IsSpecial()) {

Ditto.

> LayoutTests/media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:3
> +PASS TextTrackCue.endTime, script-created cue 
> +TIMEOUT TextTrackCue.endTime, parsed cue Test timed out

TIMEOUT? ChangeLog should note this if it is intentional.

> LayoutTests/media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:3
> +PASS TextTrackCue.startTime, script-created cue 
> +TIMEOUT TextTrackCue.startTime, parsed cue Test timed out

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.