[Webkit-unassigned] [Bug 101920] [EFL][WK2] Add APIs to get/set plug-ins.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101920





--- Comment #4 from Christophe Dumez <christophe.dumez at intel.com>  2012-12-04 02:57:32 PST ---
(From update of attachment 177455)
View in context: https://bugs.webkit.org/attachment.cgi?id=177455&action=review

Patch looks technically OK but I would improve the documentation a bit.

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Add APIs to get/set plug-ins.

"[EFL][WK2] Add APIs to toggle plug-ins support"

> Source/WebKit2/ChangeLog:8
> +        Add setting APIs for plug-ins and a unit test.

"Add setting APIs to toggle plug-ins support and add corresponding API tests."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:428
> + * Enables/disables the plug-ins.

Toggles plug-in support.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:430
> + * By default, the plug-ins is enabled.

"By default, plug-ins support is enabled."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:432
> + * @param settings settings object to set the plug-ins

"object to set plug-ins support"

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:433
> + * @param enable @c EINA_TRUE to enable the plug-ins

"to enable plug-ins support"

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:441
> + * Returns whether the plug-ins is enabled or not.

"Returns whether plug-ins support is enabled or not."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:443
> + * @param settings settings object to query whether the plug-ins is enabled

"... whether plug-ins support is enabled"

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:445
> + * @return @c EINA_TRUE if the plug-ins is enabled

"if plug-ins support is enabled"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.