[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #28 from Kalyan <kalyan.kondapally at intel.com>  2012-12-03 23:43:44 PST ---
(In reply to comment #27)
> (In reply to comment #26)
> > (In reply to comment #23)
> > > Created an attachment (id=177414)
 --> (https://bugs.webkit.org/attachment.cgi?id=177414&action=review) [details] [details] [details]
> > > Patch
> > 
> > I think canvasHasGraphicsSurface should always return false when GRAPHICS_SURFACE is not used , irrespective of whether we have a platformlayer or not.
> > 
> > I mean something like this:
> > bool CoordinatedGraphicsLayer::canvasHasGraphicsSurface() const
> > {
> > #if USE(GRAPHICS_SURFACE)
> >     if (m_canvasPlatformLayer)
> >         return true;
> > #endif
> >     return false;
> > }
> 
> canvasHasGraphicsSurface should always return true when GRAPHICS_SURFACE is >used. TRUE is default, returning false is exceptional case so if no canvas >layer exists true should be returned because it means no exceptional case. >You feel me?

k, it is bit confusing that we return true even in case GRAPHICS_SURFACE is not used (in case GraphicsLayer doesn't have a valid platformLayer).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.