[Webkit-unassigned] [Bug 103937] [chromium] fix showFPScounter and showPaintRects not toggleable after page change

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103937


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177348|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-12-03 16:00:05 PST ---
(From update of attachment 177348)
View in context: https://bugs.webkit.org/attachment.cgi?id=177348&action=review

This patch looks good (except for InspectorPageAgent interaction from within WebKit). There are two other ways it could be implemented: 1) finding a signal that would reliably trigger after layer tree is there from within WebCore or 2) creating such a signal.

> Source/WebKit/chromium/src/WebViewImpl.cpp:4048
> +#if ENABLE(INSPECTOR)

chromium === ENABLE(INSPECTOR)

> Source/WebKit/chromium/src/WebViewImpl.cpp:4049
> +            InspectorPageAgent* pageAgent = page()->inspectorController()->pageAgent();

You can only talk to InspectorController from WebKit layer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.