[Webkit-unassigned] [Bug 102686] [V8] toFastV8 for non-Nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102686





--- Comment #11 from Dan Carney <dcarney at google.com>  2012-12-03 13:07:44 PST ---
(From update of attachment 177259)
View in context: https://bugs.webkit.org/attachment.cgi?id=177259&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:589
>> +inline v8::Handle<v8::Value> toV8Fast(${nativeType}* impl, const v8::Local<v8::Object> holder, v8::Isolate* isolate, Node* node)
> 
> This seems to imply that all callers need to call GetIsolate before calling toV8Fast.  In the common path through this function, we previously avoided the GetIsolate call.  Does calling that function eagerly affect performance (I would expect it to).
> 
> It might be worth having two overloaded copies of this function: one for AccessorInfo and one for Arguments.  We could even make it a template since the code would be identical.  This function is always inlined, so there wouldn't be any cost to having two copies.

I had the two copies before but haraken didn't want it.  I thought the Isolate was needed in all paths, but I see now that it's not in the fast path.  I'll switch to a templatized method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.