[Webkit-unassigned] [Bug 103727] Unset NodeMustGenerate flag for Call nodes of few String.prototype.* pure functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 12:20:05 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=103727





--- Comment #5 from Darin Adler <darin at apple.com>  2012-12-03 12:22:30 PST ---
(From update of attachment 177258)
View in context: https://bugs.webkit.org/attachment.cgi?id=177258&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:41
> +extern const HashTable stringTable;

This is an anti-pattern. If we want to use an external symbol, we should include the header it’s declared in, not re-declare it inside a file that’s using it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list