[Webkit-unassigned] [Bug 103911] Web Inspector: more robust treeoutline.findTreeElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103911


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177296|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-12-03 12:01:52 PST ---
(From update of attachment 177296)
View in context: https://bugs.webkit.org/attachment.cgi?id=177296&action=review

> Source/WebCore/inspector/front-end/treeoutline.js:279
> +        function oneLevel() {

{ should go on the next line

I also don't think this is right: imagine you get here due to isAncestor(item.representedObject, representedObject) returning true above. And there are no tree elements created for the path from root to given representedObject yet. You get into recursive findTreeElement for the parent object as the next step, but oneLevel (isAncestor substitude) returns false and you never call onpopulate on the parent.

> Source/WebCore/inspector/front-end/treeoutline.js:282
> +        function noAncestors() {

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.