[Webkit-unassigned] [Bug 103510] Reduce the children repaints when moved multiple times during the layout
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 3 10:32:29 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=103510
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #177239|review? |review-
Flag| |
--- Comment #11 from Darin Adler <darin at apple.com> 2012-12-03 10:34:53 PST ---
(From update of attachment 177239)
View in context: https://bugs.webkit.org/attachment.cgi?id=177239&action=review
Looks pretty good. Needs a couple small improvements.
> Source/WebCore/rendering/RenderFlexibleBox.cpp:336
> + WTF::Vector<LayoutRect> childrenOldRects;
Should be just Vector. Not WTF::Vector. Also, we should choose some amount of inline capacity to cut down on memory allocation and make performance better. A number large enough that it’s often larger than the number of children, but not so large that we use a ton of stack space.
> Source/WebCore/rendering/RenderFlexibleBox.cpp:370
> +void RenderFlexibleBox::childrenFrameRects(WTF::Vector<LayoutRect>& childrenFrameRects)
No WTF prefix needed here.
A function like this that uses an out parameter should have “get” in its name. Or “append” to make clear its contract is that it appends to an existing vector.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list