[Webkit-unassigned] [Bug 103484] IndexedDB: Implement IndexedDB bindings for JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103484





--- Comment #7 from Joshua Bell <jsbell at chromium.org>  2012-12-03 09:16:05 PST ---
(From update of attachment 176820)
View in context: https://bugs.webkit.org/attachment.cgi?id=176820&action=review

>> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:228
>> +    APIEntryShim entryShim(exec);
> 
> You can use DOMRequestState::Scope.
> 
> BTW, V8 binding isn't creating a scope of DOMRequestState::Scope, which looks wrong.

All of the call sites to this function are within a script scope already, so dcarney didn't add it here. I agree it's odd for what looks like a general purpose utility function.

>> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:260
>> +    APIEntryShim entryShim(exec);
> 
> You can use DOMRequestState::Scope.
> 
> BTW, V8 binding isn't creating a scope of DOMRequestState::Scope, which looks wrong.

Ditto.

>> Source/WebCore/bindings/js/IDBBindingUtilities.cpp:278
>> +    APIEntryShim entryShim(exec);
> 
> You can use DOMRequestState::Scope.
> 
> BTW, V8 binding isn't creating a scope of DOMRequestState::Scope, which looks wrong.

And this is only called from places that have already set up a DOMRequestState::Scope.

>> Source/WebCore/bindings/js/JSIDBAnyCustom.cpp:-88
>> -        return idbAny->serializedScriptValue()->deserialize(exec, globalObject);
> 
> Why can you remove this?

SerializedScriptValues were removed from IDBAny in favor of just ScriptValues, to avoid unnecessary de/serializations.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.