[Webkit-unassigned] [Bug 77566] [CSS Grid Layout] computed grid track sizes should be pixel values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 08:13:38 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77566





--- Comment #1 from Xan Lopez <xan.lopez at gmail.com>  2012-12-03 08:16:01 PST ---
(In reply to comment #0)
> Per section 6.5.2:
> 
> "The computed size of all Grid Tracks as returned for the grid-rows and grid-columns properties are normalized to used pixel values."
> 
> I missed this part when implementing -webkit-grid-rows and -webkit-grid-columns so we currently don't always return the pixel values.

(Note, I think the right section is 4.5.2)

Dumping my brain here, since I think this might be doable. Correct me if I'm wrong but my understanding is that what we'd need to hack around here would be CSSComputedStyleDeclaration::valueForGridTrackBreadth, right? In that case:

- With the patch from bug #103335 the computed size for fixed and viewport percentage sizes is correctly returned as pixels.
- Percentage is not, mostly because I'm not sure of what value to use as the "max size" in the valueForLength call. AFAIK we really need that value for things to work correctly.

So maybe we can land bug #103335, then I can work in this bug to fix percentage. After that I'd move on to figure out the whole calc() scenario (see bug #103761), and I think we'd be mostly set.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list