[Webkit-unassigned] [Bug 103840] Text Autosizing: don't autosize horizontal menu items implemented via floating list items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103840





--- Comment #2 from John Mellor <johnme at chromium.org>  2012-12-03 06:25:47 PST ---
(From update of attachment 177149)
View in context: https://bugs.webkit.org/attachment.cgi?id=177149&action=review

Looks great, thanks! Just a few very minor nits.

> Source/WebCore/ChangeLog:9
> +        disregards such elements as autosizing containers. List items are then autosized as part of a bigger

s/are then/are often then/

> Source/WebCore/ChangeLog:12
> +        resulting in no font size multiplication for menu items.

s/for menu items/for menu items implemented in this manner/

> Source/WebCore/rendering/TextAutosizer.cpp:208
> +    // * except for floating list items or positioned out of the list's flow.

Minor nit - I'd prefer:

// - Must not be normal list items, as items in the same list should look
//   consistent, unless they are floating or position:absolute/fixed.

> LayoutTests/ChangeLog:12
> +        resulting in no font size multiplication for menu items.

s/for menu items/for menu items implemented in this manner/

> LayoutTests/fast/text-autosizing/cluster-list-item-expected.html:19
> +	<li style="position: absolute; width: 800px; font-size: 2.5rem">

>From looking at these styles, I suspect these list items are going to overlap significantly, making it hard to see what's going on in the test. Could you make sure that doesn't happen, by adding margins or clear:left etc if necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.