[Webkit-unassigned] [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 01:03:18 PST 2012


--- Comment #50 from Aivo Paas <aivopaas at gmail.com>  2012-12-03 01:05:40 PST ---
(In reply to comment #49)
> (From update of attachment 177187 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177187&action=review
> Nice to see the improvements, but since you made a change in behavior that was obviously intended for some reason, we should change that as part of another bug. Since it was an optimization, this patch can land without.
> > Source/WebCore/dom/Document.cpp:-5755
> > -    // If the mouse is down and if this is a mouse move event, we want to restrict changes in
> > -    // :hover/:active to only apply to elements that are in the :active chain that we froze
> > -    // at the time the mouse went down.
> > -    bool mustBeInActiveChain = request.active() && request.move();
> > -
> I don't think it is a good idea to change this behaviour in this patch. We should figure out why it was introduced in the first place and fix it in another bug if we think it is still a good idea.

I also thought about making the behavior change separate. Skipping the hovered() check should be enough to go without the change. I'll also dig up where the condition was introduced to see if there's a good reason for not being consistent with other browsers.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list