[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #177177|review?                     |review-
               Flag|                            |




--- Comment #19 from Noam Rosenthal <noam at webkit.org>  2012-12-02 22:15:05 PST ---
(From update of attachment 177177)
View in context: https://bugs.webkit.org/attachment.cgi?id=177177&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayer.h:45
> +    virtual bool hasGraphicsSurface() const { return true; }

I think it's better if this function returned true when GRAPHICS_SURFACE is on, and false when off, like what you did inside Canvas2DLayerEfl.cpp. 
Maybe Zeno has a different idea though :)

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:678
> +        m_canvasPlatformLayer->paintContents(*context, rect);

This is not right; 
You should paint the canvas' content after painting the regular content, and adjust it to contentsRect().
Otherwise the canvas'  background and borders would disappear.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:763
> +    if (m_canvasPlatformLayer && !m_canvasPlatformLayer->hasGraphicsSurface())
> +        setDrawsContent(true);

I don't like setting drawsContent from within CoordinatedGraphicsLayer.
Better to refactor the functions that use it, like shouldHaveBackingStore()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.