[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #15 from Kyungjin Kim <gen.kim at samsung.com>  2012-12-02 18:42:19 PST ---
(In reply to comment #8)
> View in context: https://bugs.webkit.org/attachment.cgi?id=176902&action=review
> 
> > Source/WebCore/platform/graphics/ImageBuffer.h:124
> > +        cairo_surface_t* getSurface() const { return m_data.m_surface; }
> 
> We usually name getters such as surface() directly, not getSurface().
> Also, the coding style was recently altered so that functions returning non-const pointers should not be const.
> 
> > Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.cpp:29
> > +PassRefPtr<Canvas2DLayerEfl> Canvas2DLayerEfl::create(ImageBuffer* buffer, IntSize& size)
> 
> size argument should probably be const
> 
> > Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.cpp:34
> > +Canvas2DLayerEfl::Canvas2DLayerEfl(ImageBuffer* buffer, IntSize& size)
> 
> Ditto.
> 
> > Source/WebCore/platform/graphics/efl/Canvas2DLayerEfl.h:37
> > +    , public RefCounted<Canvas2DLayerEfl> {
> 
> Looks like the comma should be inside the #if otherwise it won't build if TEXTURE_MAPPER_GL is not used.

all done. Thanks for your comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.