[Webkit-unassigned] [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101857





--- Comment #36 from Aivo Paas <aivopaas at gmail.com>  2012-12-02 13:58:38 PST ---
(In reply to comment #31)
> (From update of attachment 174920 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174920&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:1404
> > +    Settings* settings = m_frame->settings();
> > +    if (settings && !settings->deviceSupportsMouse())
> > +        return;
> > +
> > +    FrameView* view = m_frame->view();
> > +    if (!view)
> > +        return;
> > +
> > +    if (!m_frame->page() || !m_frame->page()->isOnscreen())
> > +        return;
> 
> Most of this code is duplicated from fakeMouseMoveEventTimerFired, it would be nice if it would be shared. Using a function like bool "EventHandler::canUpdateMouseCursor() const" for example.
> Also, any reason for not checking m_frame->page()->focusController()->isActive()?

I must have removed that check while experimenting with something. Will add it back.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.