[Webkit-unassigned] [Bug 95529] [chromium] Rename WebViewClient::handleDisambiguationPopup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95529


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161622|review?                     |review-
               Flag|                            |




--- Comment #4 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-08-31 15:51:18 PST ---
(From update of attachment 161622)
View in context: https://bugs.webkit.org/attachment.cgi?id=161622&action=review

>> Source/WebKit/chromium/public/WebViewClient.h:291
>> +    virtual bool multipleTargetsTapped(const WebGestureEvent&, const WebVector<WebRect>& targetRects) { return false; }
> 
> didTapMultipleTargets or willTapMultipleTargets?

+1 ... probably didTap* since this is called from handleGestureEvent.  The tap already happened.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.