[Webkit-unassigned] [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51450





--- Comment #66 from Koji Ishii <kojiishi at gmail.com>  2012-08-31 09:21:39 PST ---
(In reply to comment #61)
> (In reply to comment #60)
> > Created an attachment (id=161398)
 --> (https://bugs.webkit.org/attachment.cgi?id=161398&action=review) [details] [details]
> > Wrong, --binary was missing
> 
> Why don't you use "webkit-patch upload"?

Just wasn't familiar with it and was hesitate as I couldn't be confident enough to try it out. Tried this time.

> Anyway, the pixel results look correct to me.
> I prefer removing the test results from the patch. because
>  - The patch is too large.
>  - The results in the patch might have differences from results produced by our buildbots
>  - The results might have differences between Windows XP, Windows Vista, and Windows 7.
> 
> Adding entries like the following to TestExpectations would be enough. I'll update the expectation files later in this case.
> 
> // Need rebaseline
> BUGWK51450 WIN : fast/writing-mode/japanese-lr-text.html = IMAGE+TEXT
> BUGWK51450 WIN : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE+TEXT
> ...

Thanks for the advise, yeah, rebaseline this many files was a little pain as it was so easy for the merge to conflict. This is really helpful, thank you again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.