[Webkit-unassigned] [Bug 95187] Web Inspector: Add ability to replay XHR in network panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95187





--- Comment #33 from Andrey Adaikin <aandrey at chromium.org>  2012-08-31 02:22:39 PST ---
(From update of attachment 161641)
View in context: https://bugs.webkit.org/attachment.cgi?id=161641&action=review

> Source/WebCore/inspector/Inspector.json:878
> +                "description": "Replays XHR. The new XHR is identical to original (parameters method, async, body, headers, withCredentials, login, password are copied)",

to original -> to the original one

> Source/WebCore/inspector/InspectorInstrumentation.h:1185
> +

extra line?

> Source/WebCore/inspector/InspectorResourceAgent.cpp:600
> +void InspectorResourceAgent::replayXHR(ErrorString* errorString, const String& requestId)

"ErrorString* errorString," -> "ErrorString*," and remove UNUSED_PARAM macro below

> Source/WebCore/inspector/InspectorResourceAgent.cpp:615
> +    m_originalRequestId = String();

I guess String should have a method like clear() or reset()

> Source/WebCore/inspector/InspectorResourceAgent.h:71
> +struct XHRReplayData;

struct -> class

> Source/WebCore/inspector/NetworkResourcesData.cpp:49
> +PassRefPtr<XHRReplayData> XHRReplayData::create(String method, bool async, PassRefPtr<FormData> formData, const HTTPHeaderMap& headers, bool includeCredentials, String login, String password)

String method -> const String& method? for all other places also.

> Source/WebCore/inspector/NetworkResourcesData.h:52
> +    String method() { return m_method; }

const String& method() const;

and for other methods also.

> Source/WebCore/inspector/NetworkResourcesData.h:53
> +    bool async() { return m_async; }

bool async() const;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.