[Webkit-unassigned] [Bug 72811] [Gtk] No accessible caret-moved events found in certain content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72811


Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #160550|0                           |1
        is obsolete|                            |
 Attachment #161630|                            |review?, commit-queue?
               Flag|                            |




--- Comment #41 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com>  2012-08-31 00:57:39 PST ---
Created an attachment (id=161630)
 --> (https://bugs.webkit.org/attachment.cgi?id=161630&action=review)
proposed fix - part 3 (addressed feedback from review)

(In reply to comment #40)
> (From update of attachment 160550 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160550&action=review
> 
> looks ok otherwise
> 
> > Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:82
> > +    // ignores the paragraph or div and includes the block. We want the opposite.
> 
> it might be worth noting why GTK wants to do the opposite (since there's no link back to which bug this is fixing)

Done. Thanks for the review!

r?ing and cq?ing. But note that this patch expects/depends upon the "Part 2" patch, so I fully expect the EWS to spit up on this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.