[Webkit-unassigned] [Bug 84137] [GTK] Properly expose <legend> elements to ATs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84137





--- Comment #14 from chris fleizach <cfleizach at apple.com>  2012-08-30 20:02:28 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 161212 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=161212&action=review
> > 
> > > LayoutTests/accessibility/legend.html:52
> > > +        buildAccessibilityTree(body, 0, fieldset.titleUIElement(), "<< fieldset's titleUIElement");
> > 
> > While this method works, I find it a little hard to understand.
> 
> Method as in "code method/function"? Or method as in "method of indicating the desired object"? (Yeah, I know. Both. Because it's how I feel.)
> 
> Having said that, in this particular case I'm actually more concerned about "method of indicating the desired object". Because my plan is to tackle bug 95286 before too long, so the unclear method of code in this particular test will go away in favor of replacement code in the to-be-created accessibility-utlity.js). But I'd like to sort out what that new code should do.
> 
> So about indicating the desired object... You have ideas and/or preferences?
> * Marking it on its left with an asterisk (or your character(s) of choice)
> * Enclosing that whole line in square brackets (or the characters of choice)
> * Something else
> 

I think the mechanism is fine, I just wanted to say that for a test that checks what the titleUIElement was, this method of encoding it within a buildAXTree method is not the clearest way to indicate that. 

> > I think in addition to what you have here, doing an equality for the titleUIElement would be good.
> > 
> > something like
> > 
> > shouldBeTrue(titleUIElement.isEqual(fieldset.titleUIElement()))
> 
> Nice!
> 
> > after you build the accessibility tree code.
> > 
> > > Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:205
> > > +    
> > 
> > extra line insertion can be removed
> 
> Will do. Thanks for the review and suggestions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.