[Webkit-unassigned] [Bug 94980] [CSS Shaders] Implement transform parameter animations for CSS Custom Filters
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 30 18:14:22 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=94980
--- Comment #18 from Chiculita Alexandru <achicu at adobe.com> 2012-08-30 18:14:29 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=161594&action=review
Thanks! Looks better. Still some comments on the tests.
> Source/WebCore/platform/graphics/filters/CustomFilterTransformParameter.h:64
> + if (!from.size() || !to.size()) {
I think there's no way we could have empty transform operations here. The parser takes care of that, so maybe an assert would be good enough.
> LayoutTests/css3/filters/custom/custom-filter-animation.html:151
> + from { -webkit-filter: custom(url(../resources/vertex-transform-parameter.vs), transform rotateX(0deg) scale3d(1, 1, 1)); }
I wish we had a test with two different transform attributes like:
-webkit-filter: custom(url(../resources/vertex-transform-parameter.vs), transform1 rotateX(0deg), transform2 rotateY(90deg));
> LayoutTests/css3/filters/resources/custom-filter-parser.js:157
> + if (m.ahead().isA("(") && token.value != "matrix" && token.value != "matrix3d")
Why isn't parseFunction good enough to parse the matrix?
> LayoutTests/css3/filters/resources/custom-filter-parser.js:178
> + } else if (token.isA(transform)) {
Why do you need this? You should not be needed to parse the parameter names.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list