[Webkit-unassigned] [Bug 95444] [EFL] Simplify FrameLoaderClientEfl by adding a private method.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 30 05:33:08 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=95444





--- Comment #4 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-08-30 05:33:14 PST ---
(In reply to comment #2)
> (From update of attachment 161441 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161441&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:1057
> > +bool FrameLoaderClientEfl::isMainFrame() const
> 
> Sounds like a good idea but the name is not explicit enough IMO. How about "isLoadingMainFrame()" ?

I agree to you and will change the name as your suggestion. Thanks for nice name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list