[Webkit-unassigned] [Bug 95187] Web Inspector: Add ability to replay XHR in network panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95187





--- Comment #17 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-29 23:37:12 PST ---
(From update of attachment 161256)
View in context: https://bugs.webkit.org/attachment.cgi?id=161256&action=review

> Source/WebCore/inspector/Inspector.json:882
> +                "returns": [

Empty returns is redundant.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:333
> +void InspectorInstrumentation::didCreateXHRRequestImpl(InstrumentingAgents* instrumentingAgents, String method, bool async, PassRefPtr<FormData> formData, const HTTPHeaderMap& headers, bool includeCredentials, String login, String password)

Here and in other places: s/String/const String&/

> Source/WebCore/xml/XMLHttpRequest.cpp:689
> +    m_requestEntityBody = formData;

You are not really passing the ownership of formData here. You should pass it by pointer and deepCopy back here.

> Source/WebCore/xml/XMLHttpRequest.cpp:728
> +    InspectorInstrumentation::didCreateXHRRequest(scriptExecutionContext(), m_method, m_async, m_requestEntityBody ? m_requestEntityBody->deepCopy() : 0, m_requestHeaders, m_includeCredentials, m_url.user(), m_url.pass());

We'd better use m_requestHeaders.copyData() here instead of m_requestHeaders (and adopt() the result on the other side)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.