[Webkit-unassigned] [Bug 95258] Add support for blendmode to webkit rendering engine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95258





--- Comment #12 from Rik Cabanier <cabanier at adobe.com>  2012-08-29 16:32:14 PST ---
(In reply to comment #11)
> (From update of attachment 161330 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161330&action=review
> 
> > Source/WebCore/rendering/RenderBoxModelObject.h:90
> > +    virtual bool requiresLayer() const { return isRoot() || isPositioned() || isTransparent() || hasTransform() || hasHiddenBackface() || hasReflection() || createsGroup() || style()->specifiesColumns(); }
> 
> You also need to change RenderBox::requiresLayer() and RenderTableRow::requiresLayer().
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:1780
> > +    if (hasCompositedDescendants && (layer->transform() || renderer->isTransparent() || renderer->hasMask() || renderer->hasReflection() || renderer->hasFilter() || renderer->hasBlendMode())) {
> >          reason = RenderLayer::IndirectCompositingForGraphicalEffect;
> 
> Why not use createsGroup() here?
> 
> > Source/WebCore/rendering/RenderObject.h:943
> > +    bool createsGroup() const { return hasMask() || hasFilter() || hasBlendMode(); } 
> 
> I think this deserves a comment explaining the usage of "group". Should isTransparent() also be included?

yes, I will add that. hasTransform seems like it should be added as well, except that RenderInline does not check for that. Is it because inline is never transformed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.