[Webkit-unassigned] [Bug 94858] AX: Regression (r126369) - toggle buttons no longer return accessible titles
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 29 13:28:03 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=94858
--- Comment #6 from Dominic Mazzoni <dmazzoni at google.com> 2012-08-29 13:28:06 PST ---
Thanks for fixing this! The patch looks fine to me.
A cross-platform test would be nice - or at a minimum, a test that runs on Mac, since right now Mac gives the most WebKit test coverage. See LayoutTests/accessibility/focusable-div.html for one approach I used recently to create a cross-platform test - it just grabs the last character of the title so that it's agnostic to any prefix like 'AXTitle: '.
Alternatively, consider a test that just dumps the role and title of each button using debug(), and we could have different expectations for each platform. You can add the test to LayoutTests/accessibility and only add a gtk-specific expectation (e.g. LayoutTests/platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt) in this patch - then I'd be happy to add Mac & Chromium expectations later.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list