[Webkit-unassigned] [Bug 95187] Web Inspector: Add ability to replay XHR in network panel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95187


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161256|review?                     |review-
               Flag|                            |




--- Comment #16 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-29 12:51:20 PST ---
(From update of attachment 161256)
View in context: https://bugs.webkit.org/attachment.cgi?id=161256&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:595
> +void InspectorResourceAgent::replayXHR(ErrorString* errorString, const String& requestId)

Add ASSERT_UNUSED(errorString); below to make mac bot happy.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:602
> +    RefPtr<XHRReplayData> XHRData = m_resourcesData->XHRData(actualRequestId);

xhrData

> Source/WebCore/inspector/InspectorResourceAgent.cpp:654
> +    , m_XHRData(0)

m_xhrData

> Source/WebCore/inspector/NetworkResourcesData.h:120
> +        RefPtr<XHRReplayData> m_XHRData;

ditto

> Source/WebCore/inspector/NetworkResourcesData.h:153
> +    PassRefPtr<XHRReplayData> XHRData(const String& requestId);

ditto

> Source/WebCore/loader/DocumentThreadableLoader.cpp:386
> +            InspectorInstrumentation::preflightRequestSucceded(m_document, m_preflightRequestIdentifier);

No brackets for one line conditionals.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.