[Webkit-unassigned] [Bug 95244] ExecutableAllocator should be destructed after Heap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95244





--- Comment #6 from Yong Li <yoli at rim.com>  2012-08-29 10:12:58 PST ---
(In reply to comment #5)
> (From update of attachment 161238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161238&action=review
> 
> Did you check to make sure the Executable Allocator doesn't use the heap in its constructor?

Yes. ExecutableAllocator knows nothing about the heap. It doesn't even not use the JSGlobalData& argument. (checked in both ExecutableAllocator.cpp and ExecutableAllocatorFixedVMPool.cpp. It is just used to allocate memory for JIT assemblies. So logically it shouldn't rely on any other JS data.

> 
> > Source/JavaScriptCore/runtime/JSGlobalData.cpp:124
> > +    , heap(this, heapType)
> 
> No need for this initializer inside the #if.

Just for "," and ":"

Would this be OK then?

JSGlobalData::JSGlobalData(GlobalDataType globalDataType, ThreadStackType threadStackType, HeapType heapType)
    : 
#if ENABLE(ASSEMBLER)
      executableAllocator(*this),
#endif
      heap(this, heapType)
    , globalDataType(globalDataType)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.