[Webkit-unassigned] [Bug 5515] Border collapse problem with rowspan/colspan cells

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5515





--- Comment #32 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-08-29 08:59:42 PST ---
(In reply to comment #30)

Thanks for the review comments Robert. Have uploaded another patch with the suggested changes.

> (From update of attachment 160931 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160931&action=review
> 
> > Source/WebCore/rendering/RenderTableCell.cpp:438
> > +        if (isValidCellForColRowSpanBorderResolution(true, prevCell)) {
> >          CollapsedBorderValue prevCellBorder = CollapsedBorderValue(prevCell->style()->borderEnd(), includeColor ? prevCell->style()->visitedDependentColor(endColorProperty) : Color(), BCELL);
> 
> You're missing your indentation here.
Missed out on this.
> 
> > Source/WebCore/rendering/RenderTableCell.h:214
> > +    bool isValidCellForColRowSpanBorderResolution(bool isStartOrEndBorder, RenderTableCell* adjacentCell = 0) const;
> 
> Couldn't this helper function be static?
Done.
> 
> > LayoutTests/ChangeLog:67
> > +        Modified existing results for qt and chromium-win ports.
> 
> It's not obvious why these new results are correct - can you provide some commentary?
Added an explanation for the changes in the results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.