[Webkit-unassigned] [Bug 94472] [CSSRegions]Add support for text-shadow in region styling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94472





--- Comment #15 from Mihai Balan <mibalan at adobe.com>  2012-08-29 06:36:45 PST ---
(From update of attachment 161028)
View in context: https://bugs.webkit.org/attachment.cgi?id=161028&action=review

> LayoutTests/fast/regions/region-style-text-shadow-expected.html:10
> +             #p1 { text-shadow: 340px 100px #008000; position: absolute; top: 10px; }

Why are you manually positioning every element absolutely? It really makes the test a lot harder to read/interpret

> LayoutTests/fast/regions/region-style-text-shadow.html:14
> +             #region1 { -webkit-flow-from: flow1; position: absolute; top: 10px; }

Is there a particular reason why you manually specify the position of the regions? I would like the tests as clear and clutter free as possible :)

> LayoutTests/fast/regions/region-style-text-shadow.html:59
> +         <div id="article1">

For the sake of maintainability / readability, I would rather have one text at the bottom of the file explaining the expected output (E.g. "No red shadow should be visible") and then each "assertion" to better explain what exactly is it testing rather than having "Text shadow styled in region: <color>" over and over again :)

> LayoutTests/fast/regions/region-style-text-shadow.html:87
> +         <div id="article5">

Aren't article5 and article6 testing the same thing? (The only difference that I see is in the element used inside the <article> tag. Why do you think they would behave differently?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.