[Webkit-unassigned] [Bug 84137] [GTK] Properly expose <legend> elements to ATs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 29 03:43:18 PDT 2012


Joanmarie Diggs <jdiggs at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #161155|0                           |1
        is obsolete|                            |
 Attachment #161155|review?                     |
               Flag|                            |
 Attachment #161173|                            |review?
               Flag|                            |

--- Comment #9 from Joanmarie Diggs <jdiggs at igalia.com>  2012-08-29 03:43:20 PST ---
Created an attachment (id=161173)
 --> (https://bugs.webkit.org/attachment.cgi?id=161173&action=review)
proposed patch

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (From update of attachment 161155 [details] [details] [details])
> > > I think we probably want to move this legend test to the mac platform only, because what it is testing is that the titleUIElement is properly set, not that the tree hierarchy matches something. 

Now the test prints the hierarchy and identifies the titleUIElement within the hierarchy.

So mac results look like:

  AXRole: AXWebArea AXValue: 
      AXRole: AXGroup AXValue: 
          AXRole: AXGroup AXValue:      << fieldset's titleUIElement
              AXRole: AXStaticText AXValue: Choose a shipping method:
          AXRole: AXGroup AXValue: 
              AXRole: AXRadioButton AXValue: 0
              AXRole: AXStaticText AXValue: Overnight
      AXRole: AXGroup AXValue: 
          AXRole: AXStaticText AXValue: End of test

And gtk results look like:

  AXRole: document frame 
      AXRole: panel 
          AXRole: label AXValue: Choose a shipping method:     << fieldset's titleUIElement
          AXRole: panel 
              AXRole: radio button AXValue: 
      AXRole: section AXValue: End of test

Two completely different hierarchies, same titleUIElement, one single cross-platform layout test. :) Whatdya think?

If you don't like it, I'll go with your original suggestion namely:

> > > so let's move legend.html to mac only and rename to legend-title-element.html and use this new one in all platforms as something like legend-hierarchy.html

Thanks again!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list