[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91214





--- Comment #47 from JungJik Lee <jungjik.lee at samsung.com>  2012-08-29 02:06:10 PST ---
(From update of attachment 160672)
View in context: https://bugs.webkit.org/attachment.cgi?id=160672&action=review

>>>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:748
>>>> +#endif
>>> 
>>> Is this related to context? I think that it should be in ewk_context.
>> 
>> it's better to stay in view. because memory sampler starts when view is created. I think it's nothing related with context. though it's using it.
> 
> I still believe that it should not be in ewk_view because WebMemorySampler collects information per webprocess.
> 
> For example, we can create ewk_view from new context (which is not default context) and new context may have a way to start sampler.
> 
> Anyway, why don't you add this as ewk API to enable/disable at run-time?
> I think that it looks more useful.

if you see this (https://bugs.webkit.org/attachment.cgi?id=153474&action=review), it was early code. I had same idea but Gyuyoung said there is no such APIs for debugging or profiling. So I removed it. I can move the code to context creation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.