[Webkit-unassigned] [Bug 84137] [GTK] Properly expose <legend> elements to ATs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84137


Joanmarie Diggs <jdiggs at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161155|                            |review?
               Flag|                            |




--- Comment #3 from Joanmarie Diggs <jdiggs at igalia.com>  2012-08-29 00:40:39 PST ---
Created an attachment (id=161155)
 --> (https://bugs.webkit.org/attachment.cgi?id=161155&action=review)
proposed patch

* Created a new WebCore Accessibility Role, LegendRole.
* Used it to map to the expected platform role, ATK_ROLE_LABEL.
* Established the needed AtkRelation pair, label-for/labelled-by
  between the legend and fieldset.
* Modified legend.html to use buildAccessibilityTree() [1]
* Unskipped legend.html for Gtk.
* Added expected results for Gtk.
* Updated expected results for Mac because the output from
  buildAccessibilityTree() changes the appearance.

Please review.

[1] It's in three tests already so why not four? ;) Note that I did open bug 95286 because this handy function should be somewhere other than individual tests. Chris gave me some advice as to how. (Thanks!) So I'll give that a shot. In the meantime, if we can overlook the duplication I'd appreciate it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.