[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 28 23:24:07 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=91214
Ryuan Choi <ryuan.choi at samsung.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ryuan.choi at samsung.com
--- Comment #46 from Ryuan Choi <ryuan.choi at samsung.com> 2012-08-28 23:24:09 PST ---
(In reply to comment #37)
> (From update of attachment 160672 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160672&action=review
>
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:748
> >> +#endif
> >
> > Is this related to context? I think that it should be in ewk_context.
>
> it's better to stay in view. because memory sampler starts when view is created. I think it's nothing related with context. though it's using it.
>
I still believe that it should not be in ewk_view because WebMemorySampler collects information per webprocess.
For example, we can create ewk_view from new context (which is not default context) and new context may have a way to start sampler.
Anyway, why don't you add this as ewk API to enable/disable at run-time?
I think that it looks more useful.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list