[Webkit-unassigned] [Bug 94182] [chromium] Implement Disambiguation Popup (a.k.a. link preview, on-demand zoom)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94182





--- Comment #15 from Adam Barth <abarth at webkit.org>  2012-08-28 15:49:29 PST ---
> > View in context: https://bugs.webkit.org/attachment.cgi?id=160927&action=review
> > 
> > > Source/WebCore/page/TouchDisambiguation.cpp:46
> > > +namespace {
> > 
> > Generally, WebKit prefers to use file-level static functions rather than anonymous namespaces.
> 
> Okay, but I'll need an anonymous namespace for struct TouchTargetData anyway. Do we still prefer static function in this case?

We can also just leak the symbol for TouchTargetData.  It's not a big deal either way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.