[Webkit-unassigned] [Bug 94810] Vector::shrinkToFit should use realloc when canCopyWithMemcpy is true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94810





--- Comment #14 from Benjamin Poulain <benjamin at webkit.org>  2012-08-28 11:36:58 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=161015&action=review

So you picked the 1K based on measurement on your platform, one of the few that does not use USE_SYSTEM_MALLOC.

And you set the patch for review for all platforms. Don't you see anything wrong with that?

> Source/WTF/ChangeLog:10
> +        Use realloc to shrink buffer when it is changing from a large malloc buffer
> +        to another large one (> 1k), and canCopyWithMemcpy is true.
> +

You should give the performance analysis and the numbers in your ChangeLog.

Here is an example of a good ChangeLog of performance work: http://trac.webkit.org/changeset/124990

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.