[Webkit-unassigned] [Bug 95187] Web Inspector: XHR replay

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95187


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #160952|review?                     |review-
               Flag|                            |




--- Comment #2 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-28 05:45:59 PST ---
(From update of attachment 160952)
View in context: https://bugs.webkit.org/attachment.cgi?id=160952&action=review

Please add tests.

> Source/WebCore/inspector/Inspector.json:878
> +                "description": "Replays XHR.",

Please make this description more verbose. It should mention that XHR resent is identical to the original one and specify the concrete parameters that are identical in them.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:333
> +void InspectorInstrumentation::DidCreateXhrRequestImpl(InstrumentingAgents* instrumentingAgents, String method, bool async, PassRefPtr<FormData> formData, const HTTPHeaderMap& headers, bool includeCredentials, String login, String password)

didCreateXhrRequestImpl

> Source/WebCore/inspector/InspectorResourceAgent.h:71
> +struct XhrData;

XHRReplayData

> Source/WebCore/inspector/InspectorResourceAgent.h:-108
> -

Please revert unneeded changes.

> Source/WebCore/inspector/front-end/NetworkPanel.js:965
> +        if (request && request.type.name() === "xhr") {

request.type === WebInspector.resourceTypes.XHR

> Source/WebCore/inspector/front-end/NetworkRequest.js:801
> +        

Please revert

> Source/WebCore/loader/DocumentThreadableLoader.cpp:403
> +    if (m_preflightRequestIdentifier)

Let's make it look like 
if (m_actualRequest)
  ... 
else if (m_preflightRequestIdentifier)
  ... 
for consistency.

> Source/WebCore/xml/XMLHttpRequest.cpp:690
> +    createRequest(ec);

As discussed we should set Content-Type header here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.