[Webkit-unassigned] [Bug 5515] Border collapse problem with rowspan/colspan cells

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 04:43:43 PDT 2012


--- Comment #29 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-08-28 04:43:45 PST ---
(In reply to comment #21)
> (From update of attachment 159860 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159860&action=review
> > Source/WebCore/rendering/RenderTableCell.cpp:498
> > +    if (!isEndColumn && !(rowSpan() > 1)) {
> This fix is not right. First you are only touching half of the collapsing border functions which means that it is still broken in half of the cases. Secondly, after this change, you are ignoring adjacent rowSpan / colspan > 1 cells that still have a full common border which I think is unfortunate. The spec is silent on what we are supposed to do with rowspan / colspan but it doesn't make much sense to disallow this case, especially since we handle it properly already and other browsers seems to allow it too. I posted something similar some time ago on bug 20840 (only for the colspan case) but never followed up on it due to lack of time.
> Note that your fix is a hack around the fact that we should support border segmenting per bug 20260 and you should say it, not hide this fact. Adding this would be the best but it would make our collapsing border code more complex and we would probably run this change through the standards for inter-operability.

Hi Julien, thanks for the review.
I agree that my previous patch was a workaround; only addressing the problem at hand. 
Have tried to incorporate most cases with this patch (adjacent colspan/rowspan, patching in all areas etc.).
Have also added some more cases in the layout testcase added along with this patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list