[Webkit-unassigned] [Bug 28832] <img>.complete should return false for invalid images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28832





--- Comment #22 from Dominik Röttsches (drott) <dominik.rottsches at intel.com>  2012-08-28 04:20:14 PST ---
(In reply to comment #21)
> (From update of attachment 159631 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159631&action=review

> > LayoutTests/canvas/philip/tests/2d.drawImage.broken.html:25
> > +deferTest();
> > +
> > +// wait a moment so imageloader has time to load the image
> > +setTimeout(wrapFunction(function () {
> > +  var img = document.getElementById('broken.png');
> > +  _assertSame(img.complete, false, "img.complete", "false");
> > +  ctx.drawImage(img, 0, 0);
> > +}), 100);
> 
> This often leads to flaky tests. How do you know 100 is enough? anyway to avoid depending on time?

Maybe encode the image as a data-URI and place it inline, then put a script tag below that triggers starting the test? (Since image progress events as proposed in bug 76102 haven't been accepted yet.) I'd suggest to file a W3C Test Cases bug if you plan to change the philip test case here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.