[Webkit-unassigned] [Bug 91214] [EFL] Add WebMemorySampler feature.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 00:06:52 PDT 2012


--- Comment #41 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-28 00:06:54 PST ---
(From update of attachment 160915)
View in context: https://bugs.webkit.org/attachment.cgi?id=160915&action=review

(In reply to comment #39)

> EFL also has own ports. ex) mac, linux and windows. so even though I change the file name to WebMemorySamplerLinux.cpp, #if OS(LINUX) is still needed inside the cpp file for EFL. Or I should separate cmake file.

EFL port already uses linux file as below,

As you may know, EFL port mainly supports linux platform so far. Of course, EFL port will may support other platforms, for example, window, mac and so on. However, I think we can support it in CMake file using platform macro. As far as I know, WebKit culturally has shared common file with many ports. So, in my opinion, this patch needs to be considered to move linux directory.

> Source/JavaScriptCore/ChangeLog:3
> +        [EFL][WK2][CMAKE] Add WebMemorySampler option.

You should keep to be sync with bug title.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list