[Webkit-unassigned] [Bug 72811] [Gtk] No accessible caret-moved events found in certain content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72811





--- Comment #35 from chris fleizach <cfleizach at apple.com>  2012-08-27 16:41:27 PST ---
(From update of attachment 160678)
View in context: https://bugs.webkit.org/attachment.cgi?id=160678&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1956
> +    // Content inside span tags gets included in the parent text object.

I don't feel like this comment is adequate to explain why they're ignored at this point. 

If I had to guess it's because 

"<span> tags are inline tags and not meant to convey information if they have no other aria information on them. If we don't ignore them, then they can cause other elements to be ignored because...."

> Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp:83
> +        && parent->ariaRoleAttribute() == UnknownRole)

this seems like very specific logic. Generally we don't make inclusion decisions based on what the parent is doing. can you add a better comment here why an anonymous block, who's parent is not the body, and who's parent is not an unknown role, is ignored?

also, why does it only matter for the parent's aria role but not it's normal role?

> Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:822
> +    return role == ParagraphRole || role == HeadingRole || role == DivRole || role == CellRole || role == ListItemRole;

this patch here seems like a separate issue from the rest of this patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.