[Webkit-unassigned] [Bug 94828] [chromium] CCLayerTreeHost::finishCommitOnImplThread wrong setter order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94828





--- Comment #7 from James Robinson <jamesr at chromium.org>  2012-08-27 15:59:48 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 160720 [details] [details])
> > Definitely need a test.  What is the "something else" you allude to that corrects for this?
> 
> Writing tests now.
> 
> As for something else, updateMaxScrollPosition() which is the function dependent on call order is also invoked in CCLayerTreeHostImpl::commitComplete() once all the values are set.

Can we instead fix this so the order doesn't matter?  It seems like that is practically the case today - we make a bunch of sets and the only use the data after we're done with that.  Relying on a specific call order is a bit suspicious.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.